pixo

Summary Fixes a critical bug in where is incorrectly advanced when handling invalid matches (distance=0, length>1). Problem When the optimal parsing DP produces an invalid match with and , the existing code treats it as a literal but advances by the full match length instead of just 1 byte. This causes subsequent tokens to read from incorrect positions in the source data. Example: Token 1: → Emits literal at position 0, advances by 5 (should be 1) Token 2: → Tries to read from position 5 instead of position 1 (wrong!) Solution Changed the code to always advance by exactly 1 byte for literals, regardless of the value in the DP arrays: Changes Made Fixed advancement logic in Added comprehensive regression tests Added test for valid match handling (ensure fix doesn't break existing behavior) All existing tests pass Code is well-commented explaining the fix Testing Added two new tests in a dedicated regression test module: 1. * Tests the exact bug scenario with invalid matches Verifies tokens are created from correct positions This test fails without the fix, passes with it 2. Ensures the fix doesn't break valid match handling Tests normal operation with proper distance values [!NOTE] Fix: now treats invalid matches (, ) as a single literal and advances by exactly 1, preventing misaligned reads. Valid matches still advance by and remain unaffected. Tests*: Adds focused regression tests to cover zero-distance multi-byte cases and verify correct behavior for valid matches. Written by Cursor Bugbot for commit cd5793fbddade992c866c2f63de44a310e9c9c3b. This will update automatically on new commits. Configure here.