5 of 6 standards met
Summary Also reported in https://github.com/vercel/next.js/issues/66210 Not double invoking during Hydration was on oversight. Double invoking during Hydration ensures parity between and . Double invoking an Effect is tracked with . This was always used together with . However, during hydration we don't track side-effects i.e. set no flag causing no double invocation of Effects in Strict Mode. Now we set when we set the flag to double invoke Effects in Strict Mode when we hydrated which is conceptually like a Placement during client-render. How did you test this change? Added test (see first commit for previous behavior) Added a regression test for Activity which didn't change in behavior
Website or app material-library.com Repro steps 1. open the site 2. clicked on the view all button for categories 3. scrolled the page and stopped recording 4. clicked timeline option How often does this bug happen? Only once DevTools package (automated) react-devtools-extensions DevTools version (automated) 7.0.1-3cde211b0c Error message (automated) Cannot read properties of null (reading 'ownerDocument') Error call stack (automated) Error component stack (automated) GitHub query string (automated)
Repository: facebook/react. Description: The library for web and native user interfaces. Stars: 243638, Forks: 50649. Primary language: JavaScript. Languages: JavaScript (68.1%), TypeScript (29%), HTML (1.5%), CSS (1.1%), CoffeeScript (0.2%). License: MIT. Homepage: https://react.dev Topics: declarative, frontend, javascript, library, react, ui. Latest release: v19.2.4 (1mo ago). Open PRs: 100, open issues: 1042. Last activity: 3h ago. Community health: 100%. Top contributors: sebmarkbage, zpao, gaearon, acdlite, sophiebits, josephsavona, poteto, jimfb, trueadm, eps1lon and others.
JavaScript
Last 12 weeks ยท 178 commits
Customizable select elements have received support in Chromium 134: https://developer.chrome.com/blog/a-customizable-select https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Customizable_select Creating selects with appearance base-select work fine in React, however an error is logged in dev mode in validating DOM nesting. and React version: 19.1.0 Steps To Reproduce 1. Copy the example from MDN into a react project, or use my code sandbox 2. Open dev tools 3. Observe the warning Link to code example: https://codesandbox.io/p/sandbox/quiet-cdn-ylm323?file=%2Fsrc%2FApp.js%3A9%2C59 The current behavior A hydration warning is logged The expected behavior No error logged, no hydration errors should be happening (?)
React version: 18.3.1 Steps To Reproduce Open DevTools Network tab and check "disable cache" to see how much data is requested. 1. Render a long list of `loading="lazy"srcloading="lazy"loading="lazy"src=loadingsrc`. There used to be a bug in Firefox that caused the lazy loading to not work when loading attribute is placed after src, but it is gone and was never a problem in Chrome. Yet, somehow, the way in which React adds the nodes to DOM, reproduces the bug even in Chrome. I am personally experiencing it in Chrome version 131.0.6778.70 (64bit, windows). The expected behavior No matter the order of attributes, the behavior should be as per the standard browser behavior. It shouldn't matter that it's React appending the nodes or which time it's doing it.
Summary Fixes #35923 When the component renders with an empty list (or when the portal container is missing), the component returns and the portal `useLayoutEffectrepositionToFit(ref.current, ...)ref.currentnullContextMenucontextMenu-test.jsitems` is empty (reproduces the exact error from the issue) 2. Verifies the component renders correctly when items are provided Steps to reproduce the original bug: 1. Open React DevTools 2. Record a profiling session 3. Switch to the Timeline tab 4. Right-click on the canvas area (not on a specific event) With this fix, the right-click on an empty area no longer crashes.