4 of 6 standards met
Repository: facebook/hhvm. Description: A virtual machine for executing programs written in Hack. Stars: 18605, Forks: 3079. Primary language: C++. Languages: C++ (44.1%), Hack (30.1%), OCaml (11.9%), Rust (9.5%), Python (1.5%). Homepage: https://hhvm.com Topics: hack, hacklang, hhvm, php. Latest release: HHVM-3.15.0 (9y ago). Open PRs: 100, open issues: 426. Last activity: 54m ago. Community health: 87%. Top contributors: edwinsmith, jdelong, oulgen, jano, ljw1004, yfeldblum, ricklavoie, vassilmladenov, fredemmott, ptarjan and others.
C++
Last 12 weeks · 2284 commits
Address some straightforward test failures in HHVM OSS: Gate tests for internal Meta extensions behind appropriate runif checks. Set for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS. Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242. Remove a hardcoded fbcode reference.
The Squangle connection pointer wrapped by AsyncMysqlConnection may be nullptr if the connection was closed or is currently busy waiting for the result of an async query. Most code paths already call either verifyValidConnection() to raise an appropriate Hack exception or explicitly check for and handle a null backing connection, but Query::toString__FOR_DEBUGGING_ONLY() and the SSL-related getters from D33663743 do not, which can lead to segfaults. Slightly simplified reproducer from #8678: and for : Call verifyValidConnection() in all these cases, as raising an appropriate exception (e.g. closed/busy connection) seems appropriate here. Fixes #8678