Community health
5 of 6 standards met
87
✓README✓License✓Contributing✓Code of Conduct○Issue Template✓PR Template
Recent PRs & issues
Active · Last activity 30m ago
See all on GitHub →Intl.NumberFormat.format() throws "Cannot convert BigInt to number" when passed a bigint on AndroidOpenIssue
Bug Description throws when passed a argument on Android. The same code works correctly in V8 (Chrome) and SpiderMonkey (Firefox). [x] I have run and confirmed this bug does not occur with JSC [x] The issue is reproducible with the latest version of React Native. Hermes git revision (if applicable): bundled with React Native 0.81.5 React Native version: 0.81.5 OS: Android Platform: arm64-v8a Steps To Reproduce 1. Create a React Native app with Hermes enabled (default for RN 0.81.5) 2. Run on an Android device or emulator 3. Execute any of the following: The crash occurs regardless of whether the is created via the constructor or a bigint literal (), and regardless of whether a locale argument is provided. Workaround: The Expected Behavior All three expressions should return without throwing, as is a valid argument per ECMA-402 and works correctly on V8 and SpiderMonkey. Related open issues: #1317 — can't always display sign #789 — truncates currency sign on Android
Recent fixes
and called on their argument, which rejected BigInt with "Cannot convert BigInt to number". Per ECMA-402, both methods must accept BigInt. Changes : Replaced with in both and . Added shared helper for Number/BigInt handling. For BigInt inputs, conversion to is now validated to be exact: non-finite conversion results are rejected, round-trip check () is used to detect precision loss, imprecise conversions throw instead of silently rounding. : Removed try/catch that masked failures. Added coverage for positive, negative, and zero BigInt inputs to both and . Added regression checks that large imprecise BigInt values (e.g. ) throw for both APIs. This keeps BigInt accepted where possible while avoiding silent precision loss in the platform formatting layer. Original prompt This section details on the original issue you should resolve* Intl.NumberFormat.format() throws "Cannot convert BigInt to number" when passed a bigint on Android ## Bug Description throws when passed a argument on Android. The same code works correctly in V8 (Chrome) and SpiderMonkey (Firefox). [x] I have run and confirmed this bug does not occur with JSC [x] The issue is reproducible with the latest version of React Native. Hermes git revision (if applicable): bundled with React Native 0.81.5 React Native version: 0.81.5 OS: Android Platform: arm64-v8a ## Steps To Reproduce 1. Create a React Native app with Hermes enabled (default for RN 0.81.5) 2. Run on an Android device or emulator 3. Execute any of the following: The crash occurs regardless of whether the is created via the constructor or a bigint literal (), and regardless of whether a locale argument is provided. Workaround: ## The Expected Behavior All three expressions should return without throwing, as is a valid argument per ECMA-402 and works correctly on V8 and SpiderMonkey. Related open issues: facebook/hermes#1317 — can't always display sign facebook/hermes#789 — truncates currency sign on Android Investigate this bug in Intl (it has been reproduced on Android and MacOS, and likely is everywhere) and fix it. ## Comments on the Issue (you are @copilot in this section) Fixes facebook/hermes#1928 ✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Structured data for AI agents
Repository: facebook/hermes. Description: A JavaScript engine optimized for running React Native. Stars: 10816, Forks: 738. Primary language: JavaScript. Languages: JavaScript (54.4%), C++ (35.1%), C (4.5%), Rust (2.5%), TypeScript (0.9%). License: MIT. Latest release: v0.13.0 (1y ago). Open PRs: 62, open issues: 124. Last activity: 30m ago. Community health: 87%. Top contributors: avp, neildhar, micleo2, lavenzg, tmikov, kodafb, Huxpro, mhorowitz, jpporto, tsaichien and others.